Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTable] Not clear description prop use #4333

Closed
dej611 opened this issue Dec 3, 2020 · 2 comments
Closed

[EuiTable] Not clear description prop use #4333

dej611 opened this issue Dec 3, 2020 · 2 comments
Labels

Comments

@dej611
Copy link
Contributor

dej611 commented Dec 3, 2020

I've tried to use the description prop in a EuiBasicTable and was expecting to have it set as title for the column, but it seems ignored.

In the prop documentation it mentions:

A description of the column (will be presented as a title over the column header)

But then in the EuiBasicTable code the prop gets extracted but not used:

Live example:
https://codesandbox.io/s/friendly-wing-8fd1v?fontsize=14&hidenavigation=1&theme=dark

@elizabetdev
Copy link
Contributor

elizabetdev commented Dec 3, 2020

Hi @dej611,

I tried to investigate this issue and I believe this functionality never worked.

When the EuiBasicTable was introduced in #377 I can see a description prop for (FieldDataColumn | ComputedColumn | ActionsColumn)[] but it was only implemented properly in the ActionsColumn.

The code evolved and was migrated to TS and it seems that this issue was never fixed. The DefaultItemAction is the only one with the description prop properly implemented.

return enabled && action.description ? (
<EuiToolTip content={action.description} delay="long">
{button}
</EuiToolTip>

With that said, we need to fix the code to allow the description to be presented as a title over the column header.

@hetanthakkar
Copy link
Contributor

Working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants