Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSelectable] onFocusBadge should be customizable per item #4361

Closed
myasonik opened this issue Dec 7, 2020 · 4 comments
Closed

[EuiSelectable] onFocusBadge should be customizable per item #4361

myasonik opened this issue Dec 7, 2020 · 4 comments

Comments

@myasonik
Copy link
Contributor

myasonik commented Dec 7, 2020

onFocusBadge is currently a boolean or a custom badge. For Kibaba, where we have multiple item types, we need a custom badge per item.

Would be good if onFocusBadge supported passing in a callback which could run on each option to create a custom badge. Alternatively, maybe onFocusBadge needs to be moved into the rendered option itself and not be something managed by EuiSelectable? Rather, an option gets a isFocused flag passed into it?

Multiple ways to accomplish this probably.

@myasonik
Copy link
Contributor Author

myasonik commented Dec 8, 2020

There's also a feature request to add a divider between tags and the badge. While I think this could be done either way (with a callback for the badge or passing a isFocused flag into the option), I think giving more control to the option renderer would be the more flexible and easier way forward.

101496583-eef5c200-3937-11eb-8eae-f01cc28cd1f0

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

github-actions bot commented Dec 4, 2021

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants