[EuiColorStops] Fixed outline flashing when clicking or adding a stop #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4900/ |
cchaos
suggested changes
Jun 21, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4900/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4900/ |
cchaos
approved these changes
Jun 24, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4900/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR almost fixes the EuiColorStops outline flashing in Safari when clicking or adding a stop.
Design improvement
The focus state is now more consistent with the stop focus state.
Behavior in Safari
It seems that the issue is fixed but if we press the mouse until we're dragging the outline appears. This behavior doesn't happen in other browsers.
Screen+Recording+2021-06-24+at+10.45+AM.mov
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes