-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiPortal] Shadow DOM Support for Portal-Based Components (e.g., Modal, Overlay Mask) #6882
Comments
Fascinating idea! We've been discussing adding more non-Emotion defaults to Just out of curiosity, would adding one-off props (e.g. |
Yes, adding one-off props like |
One-off props will likely be our approach for now, as we can implement that quickly (within the next week or so), whereas wiring up We'll keep this issue open until a global |
Is your feature request related to a problem? Please describe.
I'm developing a browser extension project using Elastic UI (EUI) and would like to render EUI components within the Shadow DOM to isolate styles and avoid conflicts. However, I noticed that the Modal component's DOM elements are automatically inserted into the
document.body
, and I can't specify the target location for insertion. Specifically, I'm unable to utilize theinsert
property in thesrc/components/portal/portal.tsx
for the Modal component.Describe the solution you'd like
To facilitate global configuration of the
insert
property for portals, I suggest adding aPortalProvider
and integrating it into theEuiProvider
. This would allow for seamless management and customization of the insertion behavior of portal-based components.Additional context
Example Repo: https://github.com/y1j2x34/eui-shadow-dom-example
After clicking the "Open Modal" button, a div element with the attribute value "data-euiportal" is generated, which should be inserted at the location pointed to by the arrow for isolated CSS styling.
This issue may be due to my inability to find the correct usage. I would greatly appreciate your response as it would be very helpful for me. Thank you very much!
The text was updated successfully, but these errors were encountered: