Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prevent overflow in EuiToolTip #758

Closed
peteharverson opened this issue May 2, 2018 · 4 comments
Closed

Add option to prevent overflow in EuiToolTip #758

peteharverson opened this issue May 2, 2018 · 4 comments
Labels

Comments

@peteharverson
Copy link

Long strings in the title or content attributes of EuiToolTip will overflow. e.g.

image

It would be useful to have something like a 'word-break' attribute to control the line breaking.

Found in version 0.0.44

@snide
Copy link
Contributor

snide commented May 2, 2018

We had something like this come up earlier in the week in a different component. Is anyone opposed to us treating such issues with utility classes and components so the engineer can define the functionality they need? I don't think adding word-wrap, text alignment and other similar items to all of our wrapper components will scale very well.

Does anything think they should be components vs. just simple one-off css classes?

Options I can think of:

Separated components for properties.

<EuiTooltip title={<EuiWordBreak value="breakAll">My_log_title</EuiWordBreak>}>

A catchall utility component

<EuiTooltip title={<EuiUtility type="breakAll />My_log_title</EuiUtility>}>

Or simple utility classes

<EuiTooltip title={<div className="euiUtilityBreakAll">My_log_title</div>}>

I think I'm leaning towards plain css classes here. I can't see anytime we'd ever change their format or namespacing once a pattern was started? Then we could just make a doc page to example them all out?

cc @chandlerprall @cchaos

@snide
Copy link
Contributor

snide commented May 2, 2018

cc @zinckiwi as well

@zinckiwi
Copy link
Contributor

zinckiwi commented May 3, 2018

+1 for plain classes. At least start with that and if we feel we need something beyond it, we should be able to articulate why.

@peteharverson
Copy link
Author

The plain CSS classes would work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants