-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to prevent overflow in EuiToolTip #758
Comments
We had something like this come up earlier in the week in a different component. Is anyone opposed to us treating such issues with utility classes and components so the engineer can define the functionality they need? I don't think adding word-wrap, text alignment and other similar items to all of our wrapper components will scale very well. Does anything think they should be components vs. just simple one-off css classes? Options I can think of: Separated components for properties. <EuiTooltip title={<EuiWordBreak value="breakAll">My_log_title</EuiWordBreak>}> A catchall utility component <EuiTooltip title={<EuiUtility type="breakAll />My_log_title</EuiUtility>}> Or simple utility classes <EuiTooltip title={<div className="euiUtilityBreakAll">My_log_title</div>}> I think I'm leaning towards plain css classes here. I can't see anytime we'd ever change their format or namespacing once a pattern was started? Then we could just make a doc page to example them all out? |
cc @zinckiwi as well |
+1 for plain classes. At least start with that and if we feel we need something beyond it, we should be able to articulate why. |
The plain CSS classes would work for me. |
Long strings in the
title
orcontent
attributes ofEuiToolTip
will overflow. e.g.It would be useful to have something like a 'word-break' attribute to control the line breaking.
Found in version 0.0.44
The text was updated successfully, but these errors were encountered: