Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve combobox single item styling #919

Closed
timroes opened this issue Jun 12, 2018 · 5 comments
Closed

Improve combobox single item styling #919

timroes opened this issue Jun 12, 2018 · 5 comments

Comments

@timroes
Copy link
Contributor

timroes commented Jun 12, 2018

We currently render a singleSelection={true} combobox the same as any other:

screenshot-20180612-195951

I think we should rethink that behavior, since this combobox still looks a lot like you would be able to select multiple values, since the single value is rendered in it's tag form. To be a proper replacement to the current aggregation selection we would need the selected value to look like a single value to not misguide the user.

screenshot-20180612-200151

@cchaos
Copy link
Contributor

cchaos commented Jun 12, 2018

@timroes To better understand your use case, why would you decide to use the EuiComboBox over a EuiSelect for single selection?

@timroes
Copy link
Contributor Author

timroes commented Jun 12, 2018

Because we want grouping and search available in the component.

@snide
Copy link
Contributor

snide commented Jun 12, 2018

Labeling this style only since it doesn't involve a functionality change. I agree we could probably improve the styling a bit, but I wouldn't consider this a blocker at the moment.

@cqliu1
Copy link
Contributor

cqliu1 commented Jul 9, 2018

This is similar to my request in #854.

@cchaos
Copy link
Contributor

cchaos commented Sep 12, 2018

This was fixed in #1139 via singleSelection.asPlainText: bool

@cchaos cchaos closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants