Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Add K6 overrides to light theme. #149

Closed
wants to merge 1 commit into from

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Nov 14, 2017

DO NOT MERGE.

☠️ ☠️ ☠️

This branch is intended to be consumed by Kibana 6.x. By providing a K6 theme over the K7 components, we're hoping to enable Kibana engineers to consume this framework today, while retaining a consistent look-and-feel in the Kibana UI.

Guidelines

  1. Only override SCSS variables.
  2. If necessary, abstract parts of KUI behind variables and mixins to enable No Elasticsearch assets SVG #1.
  3. Avoid overriding selectors and styles directly as much as possible. Only do this as a last resort.

K6 theme

The K6 theme consists of:

  1. Changing colors to match the palette.
  2. Changing font-size to match.
  3. Changing some spacing to match, which generally just means making spacing tighter.

@bevacqua
Copy link
Contributor

Maybe make it an actual branch?

@cjcenizal
Copy link
Contributor Author

@bevacqua Good idea! Replacing this with #153

@cjcenizal cjcenizal closed this Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants