From 83d7b44f4708fba1d2bd248987654e4a8d6ecc71 Mon Sep 17 00:00:00 2001 From: Ryan Keairns Date: Thu, 9 Jan 2020 08:07:48 -0600 Subject: [PATCH 1/3] Lighten hollow badge border in dark mode --- src/components/badge/_badge.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/badge/_badge.scss b/src/components/badge/_badge.scss index e021e5ac322..1333a8623f7 100644 --- a/src/components/badge/_badge.scss +++ b/src/components/badge/_badge.scss @@ -126,6 +126,6 @@ // Hollow has a border and is mostly used for autocompleters. .euiBadge--hollow { background-color: $euiColorEmptyShade; - border-color: $euiBorderColor; + border-color: lightOrDarkTheme($euiBorderColor, tint($euiBorderColor, 15%)); color: $euiTextColor; } From 20775bae6d6d018200d902d584752b07e69aab1f Mon Sep 17 00:00:00 2001 From: Ryan Keairns Date: Thu, 9 Jan 2020 08:38:59 -0600 Subject: [PATCH 2/3] add CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 044def9a5ef..5bed249952e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) +- Changed `EuiBadge` hollow border color in dark mode ([#2746](https://github.com/elastic/eui/pull/2746)) - Changed `EuiBadge` to use EUI palette colors ([#2455](https://github.com/elastic/eui/pull/2455)) - Darkened a few `euiPaletteColorBlind` colors ([#2455](https://github.com/elastic/eui/pull/2455)) - Fixed bug in `EuiCard` where button text was not properly aligned ([#2741](https://github.com/elastic/eui/pull/2741)) From 3fbf4e57a20b46cef6acaa9268fc8e2e615be99f Mon Sep 17 00:00:00 2001 From: Ryan Keairns Date: Thu, 9 Jan 2020 10:08:09 -0600 Subject: [PATCH 3/3] Update CHANGELOG.md Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5bed249952e..44898795052 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -- Changed `EuiBadge` hollow border color in dark mode ([#2746](https://github.com/elastic/eui/pull/2746)) +- Lightened `EuiBadge` hollow border color in dark mode ([#2746](https://github.com/elastic/eui/pull/2746)) - Changed `EuiBadge` to use EUI palette colors ([#2455](https://github.com/elastic/eui/pull/2455)) - Darkened a few `euiPaletteColorBlind` colors ([#2455](https://github.com/elastic/eui/pull/2455)) - Fixed bug in `EuiCard` where button text was not properly aligned ([#2741](https://github.com/elastic/eui/pull/2741))