From f1a334544635323561d6651c1b4b636d319db27f Mon Sep 17 00:00:00 2001 From: miukimiu Date: Fri, 20 Mar 2020 15:17:30 +0000 Subject: [PATCH 1/4] Adding darker background on focus state --- src/components/button/button_empty/_button_empty.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/button/button_empty/_button_empty.scss b/src/components/button/button_empty/_button_empty.scss index 70fce6cd5ee..72680608485 100644 --- a/src/components/button/button_empty/_button_empty.scss +++ b/src/components/button/button_empty/_button_empty.scss @@ -89,7 +89,7 @@ $euiButtonEmptyTypes: ( &:focus { @if ($name == 'text') { - background-color: $euiColorLightestShade; + background-color: transparentize($euiTextColor, .9); } @else { background-color: transparentize($color, .9); } From 9d1014c8db4c19fc06ecc482cac635126956fce9 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Fri, 20 Mar 2020 15:47:52 +0000 Subject: [PATCH 2/4] removing unecessary if statement --- src/components/button/button_empty/_button_empty.scss | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/components/button/button_empty/_button_empty.scss b/src/components/button/button_empty/_button_empty.scss index 72680608485..60097e1e2e3 100644 --- a/src/components/button/button_empty/_button_empty.scss +++ b/src/components/button/button_empty/_button_empty.scss @@ -88,11 +88,7 @@ $euiButtonEmptyTypes: ( } &:focus { - @if ($name == 'text') { - background-color: transparentize($euiTextColor, .9); - } @else { - background-color: transparentize($color, .9); - } + background-color: transparentize($color, .9); } &:hover { From a9bb5dbcaddca50627f9c0b27e2f699462e14a86 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Fri, 20 Mar 2020 15:58:10 +0000 Subject: [PATCH 3/4] Adding changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d1968950eda..67b7ffd6b2b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ - Added `title` to headers of `EuiTable` in case of truncation ([#3094](https://github.com/elastic/eui/pull/3094)) - Added i18n to `EuiTableHeaderCell` ([#3094](https://github.com/elastic/eui/pull/3094)) - Added `number` and `string` to `size` type of `EuiImage` for setting custom sizes ([#3012](https://github.com/elastic/eui/pull/3012)) +- Improved `EuiButtonEmpty` focus state when the color type is text ([#3135](https://github.com/elastic/eui/pull/3135)) **Bug Fixes** From e40d6f936ade3607b061871465b0cdcc3c8612b0 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Fri, 20 Mar 2020 16:02:05 +0000 Subject: [PATCH 4/4] Improving changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 67b7ffd6b2b..bc1044a07be 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ - Added `title` to headers of `EuiTable` in case of truncation ([#3094](https://github.com/elastic/eui/pull/3094)) - Added i18n to `EuiTableHeaderCell` ([#3094](https://github.com/elastic/eui/pull/3094)) - Added `number` and `string` to `size` type of `EuiImage` for setting custom sizes ([#3012](https://github.com/elastic/eui/pull/3012)) -- Improved `EuiButtonEmpty` focus state when the color type is text ([#3135](https://github.com/elastic/eui/pull/3135)) +- Improved `EuiButtonEmpty` focus state when the `color` type is `text` ([#3135](https://github.com/elastic/eui/pull/3135)) **Bug Fixes**