Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): use workspace version of eui #8179

Merged

Conversation

weronikaolejniczak
Copy link
Contributor

Summary

When working with the new docs page, local changes to the EUI library are not reflected. That's because website package doesn't use workspace version of eui.

For context: Slack

QA

Test path

  1. Run yarn to install deps.
  2. Run yarn workspaces foreach -Rpti --from @elastic/eui-website run build to build all local dependency packages.
  3. Run yarn workspace @elastic/eui-website start to run the new docs website.
  4. Choose any component doc page. Change that component's source code (e.g. color).
  5. Run yarn workspace @elastic/eui build and reload the page. The changes should be visible.

Screenshot 2024-11-22 at 22 00 14
(context: #8177)

@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner November 22, 2024 21:00
@weronikaolejniczak weronikaolejniczak force-pushed the chore/website-workspace-eui branch 2 times, most recently from bf04237 to 8d6adf3 Compare November 22, 2024 21:06
@weronikaolejniczak weronikaolejniczak force-pushed the chore/website-workspace-eui branch from 8d6adf3 to df9a869 Compare November 25, 2024 09:24
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍
I'd wait for @tkajtoch to determine if we can merge this or if there is something else needed first to ensure releases have correct versions?

@cee-chen cee-chen requested a review from tkajtoch November 27, 2024 17:40
Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it seems to work perfectly fine! LGTM

@tkajtoch tkajtoch merged commit 7ec3faf into elastic:main Dec 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants