From d68388e2ab8cb9127df04b62806eb983c55b4ab9 Mon Sep 17 00:00:00 2001 From: cchaos Date: Tue, 22 May 2018 16:32:06 -0400 Subject: [PATCH 1/5] Fixes #855 Add fallback to just break-all in FF and IE --- src/global_styling/utility/_utility.scss | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/global_styling/utility/_utility.scss b/src/global_styling/utility/_utility.scss index bd51115aaeb..c3bef018aef 100644 --- a/src/global_styling/utility/_utility.scss +++ b/src/global_styling/utility/_utility.scss @@ -13,11 +13,15 @@ .eui-textCenter {text-align: center !important;} .eui-textLeft {text-align: left !important;} .eui-textRight {text-align: right !important;} -.eui-textBreakWord {word-break: break-word !important;} -.eui-textBreakAll {word-break: break-all !important;} .eui-textNoWrap {white-space: nowrap !important;} .eui-textInheritColor {color: inherit !important;} +.eui-textBreakAll {word-break: break-all !important;} +.eui-textBreakWord { + word-break: break-all !important; // Fallback for FF and IE + word-break: break-word !important; +} + /** * Text truncation * From 9d8b9edd41a260799df8f9ac77d3618e39113ca5 Mon Sep 17 00:00:00 2001 From: cchaos Date: Tue, 22 May 2018 16:33:44 -0400 Subject: [PATCH 2/5] Fixed text color of descriptions in cards --- src/components/card/_card.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/card/_card.scss b/src/components/card/_card.scss index 9ac04f65ba3..9a481f6d6b9 100644 --- a/src/components/card/_card.scss +++ b/src/components/card/_card.scss @@ -123,6 +123,7 @@ $euiCardTitleSize: 18px; // Hardcoded pixel value for theme parity. } .euiCard__description { + color: $euiTextColor; // Ensures regular text color if wrapped in an anchor tag margin-top: $euiCardSpacing/2; } } From 17ef08a8426e1530fe98ec1d0b0112cc411ee5e6 Mon Sep 17 00:00:00 2001 From: cchaos Date: Tue, 22 May 2018 16:47:06 -0400 Subject: [PATCH 3/5] Fixed vertical alignment of combo box arrow icon --- .../form/form_control_layout/_form_control_layout.scss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/form/form_control_layout/_form_control_layout.scss b/src/components/form/form_control_layout/_form_control_layout.scss index 5d15a76d368..7e197063cea 100644 --- a/src/components/form/form_control_layout/_form_control_layout.scss +++ b/src/components/form/form_control_layout/_form_control_layout.scss @@ -27,7 +27,11 @@ .euiFormControlLayout__iconButton { pointer-events: all; - top: $euiFormControlPadding - 1px; + @include size($euiSize); + + .euiIcon { + vertical-align: baseline; + } @at-root { .euiFormControlLayout--compressed#{&} { From f03791a997bfbf82eff858aa92b8aec8ad4fd5f4 Mon Sep 17 00:00:00 2001 From: cchaos Date: Tue, 22 May 2018 17:02:42 -0400 Subject: [PATCH 4/5] changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 34f33c64fa6..b065ca3cf6e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,8 @@ **Bug fixes** - `EuiButton`, `EuiButtonEmpty`, and `EuiButtonIcon` now look and behave disabled when `isDisabled={true}` ([#862](https://github.com/elastic/eui/pull/862)) +- Added FF/IE fallback for `.eui-textBreakWord` ([#864](https://github.com/elastic/eui/pull/864)) +- Fixed `EuiCard` description text color when used in/as an anchor tag ([#864](https://github.com/elastic/eui/pull/864)) ## [`0.0.49`](https://github.com/elastic/eui/tree/v0.0.49) From c3a530a884e982bf22f0e99fb98c22cc5c00962d Mon Sep 17 00:00:00 2001 From: cchaos Date: Tue, 22 May 2018 17:42:24 -0400 Subject: [PATCH 5/5] Fixed `EuiCard` IE bugs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - `EuiBetaBadge` wasn't displying outside of card bounds - Image bounds weren’t being correctly calculated - IE doesn’t accept `calc` in transforms --- CHANGELOG.md | 1 + src/components/card/_card.scss | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b065ca3cf6e..8cdc08c1dc2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - `EuiButton`, `EuiButtonEmpty`, and `EuiButtonIcon` now look and behave disabled when `isDisabled={true}` ([#862](https://github.com/elastic/eui/pull/862)) - Added FF/IE fallback for `.eui-textBreakWord` ([#864](https://github.com/elastic/eui/pull/864)) - Fixed `EuiCard` description text color when used in/as an anchor tag ([#864](https://github.com/elastic/eui/pull/864)) +- Fixed `EuiCard` IE bugs ([#864](https://github.com/elastic/eui/pull/864)) ## [`0.0.49`](https://github.com/elastic/eui/tree/v0.0.49) diff --git a/src/components/card/_card.scss b/src/components/card/_card.scss index 9a481f6d6b9..f0151117e70 100644 --- a/src/components/card/_card.scss +++ b/src/components/card/_card.scss @@ -10,6 +10,9 @@ $euiCardTitleSize: 18px; // Hardcoded pixel value for theme parity. /** * 1. Footer is always at the bottom. * 2. Extend beta badges to at least 40% of the card's width + * 3. Fix for IE to ensure badges are visible outside of a