From c8e4cb0d3ee1260e49013703b3af53ee0b209236 Mon Sep 17 00:00:00 2001 From: Shaunak Kashyap Date: Thu, 21 Jun 2018 01:13:01 -0700 Subject: [PATCH 1/2] Providing selection target for functional tests With this change, functional tests of code consuming this component can select the code editor element. --- .../code_editor/__snapshots__/code_editor.test.js.snap | 2 ++ src/components/code_editor/code_editor.js | 1 + 2 files changed, 3 insertions(+) diff --git a/src/components/code_editor/__snapshots__/code_editor.test.js.snap b/src/components/code_editor/__snapshots__/code_editor.test.js.snap index 3103632ffb9..dca5af06c30 100644 --- a/src/components/code_editor/__snapshots__/code_editor.test.js.snap +++ b/src/components/code_editor/__snapshots__/code_editor.test.js.snap @@ -78,6 +78,7 @@ exports[`EuiCodeEditor behavior hint element should be tabable 1`] = ` exports[`EuiCodeEditor is rendered 1`] = `
{prompt} From 49b22c26f8bfd61de3e95cd406dde1a4e7827aab Mon Sep 17 00:00:00 2001 From: Shaunak Kashyap Date: Thu, 21 Jun 2018 01:21:28 -0700 Subject: [PATCH 2/2] Adding release note --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d58567d577c..90ee58bb308 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ - Added `getPopoverScreenCoordinates` service function for positioining popover/tooltip content, updated `EuiToolTip` to use it ([#924](https://github.com/elastic/eui/pull/924)) - Allow `mode` prop in `EuiCodeEditor` to take custom mode object ([#935](https://github.com/elastic/eui/pull/935)) +- `EuiCodeEditor` is now decorated with a `data-test-subj` selector (`codeEditorContainer`) ([#939](https://github.com/elastic/eui/pull/939)) ## [`0.0.54`](https://github.com/elastic/eui/tree/v0.0.54)