ingress networking.k8s.io/v1beta1 is deprecated

[zerkms]

Chart version: 7.12.0

Kubernetes version: 1.19

Kubernetes provider: E.g. GKE (Google Kubernetes Engine) n/a

Helm Version: n/a

helm get release output n/a

e.g. helm get elasticsearch (replace elasticsearch with the name of your helm release)

Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting.

If you find some secrets in plain text in helm get release output you should use Kubernetes Secrets to managed them is a secure way (see Security Example).

Output of helm get release

Describe the bug:
As of kubernetes 1.19 networking.k8s.io/v1beta1 version of Ingress is deprecated and is to be removed in kubernetes 1.22

It should be upgraded to networking.k8s.io/v1

Deprecation details: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122

Steps to reproduce:

1. helm-charts/elasticsearch/templates/ingress.yaml

   Lines 5 to 6 in b3a4b75

   	apiVersion: networking.k8s.io/v1beta1
   	kind: Ingress

Expected behavior:

Provide logs and/or server output (if relevant):

Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting

Any additional context:

[jmlrt]

Hi @zerkms, thanks for submitting this issue 👍🏻

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[zerkms]

Right, I may do a PR if nobody from the team decides to fix themselves then :-)

[maybe-sybr]

@jmlrt - bumping this to draw your attention to #1233 and the recently submitted #1312 . Could we aim to land one of these PRs soon?

[ruckc]

Bumping this again as kibana refuses to deploy on kubernetes 1.22, which was released 10 days ago.

The recommended way to define API versions in helm is something like this from kube-prometheus-stack. It detects the current Kubernetes version, and uses the best apiversion for it.

[pjaak]

Any update on this? Thanks

[olevitt]

Any update ? Kubernetes 1.22 has been out for 2 months now. #1233 or #1312 should fix this and make the chart 1.22 compatible

[ruckc]

@jmlrt - those changes are not the ideal way to solve this issue.

Ideally you version check to determine which apiVersion you should support:

{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1
{{- else if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
{{- end }}

[jmlrt]

Yeah, that was the initial plan but as we removed the support of K8S 1.18 in #1410 we decided to skip the additional code for handling the previous apiVersion.

People using K8S 1.18 or lower can stay with the previous version of these charts.