Remove not needed files in Docker image #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in the docker images all packages existed twice, in the `dev` directory which is need to build the packages and then under `public`. At the moment this does not amake a big difference but in the future with many packages, this would duplicate the size of the container. Because of this as a last step, the dev directory is removed. I also took this opportunity to remove a few more files from the Docker image which are only used for testing or CI. Like this we ship an image with only the relevant files. In the future we might remove even more files like the Golang code and only ship the binary. But I keep this for a later point.
jfsiii
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the docker images all packages existed twice, in the
devdirectory which is need to build the packages and then underpublic. At the moment this does not amake a big difference but in the future with many packages, this would duplicate the size of the container. Because of this as a last step, the dev directory is removed.I also took this opportunity to remove a few more files from the Docker image which are only used for testing or CI. Like this we ship an image with only the relevant files. In the future we might remove even more files like the Golang code and only ship the binary. But I keep this for a later point.