Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package generation to its own binary #112

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Sep 24, 2019

Generating a package to be served by the package registry can be used in different places. This extracts the generation of it to its own binary. The binary can be found under dev/generator and be built with go build ..

The binary takes 2 params:

  • sourceDir: Path to the source directory of the packages
  • publicDir: Public directory where the packages should be copied to and built

This might look like go run . -sourceDir=../packages -publicDir=./public

Generating a package to be served by the package registry can be used in different places. This extracts the generation of it to its own binary. The binary can be found under `dev/generator` and be built with `go build .`.

The binary takes 2 params:

* `sourceDir`: Path to the source directory of the packages
* `publicDir`: Public directory where the packages should be copied to and built

This might look like `go run . -sourceDir=../packages -publicDir=./public`
@ruflin ruflin marked this pull request as ready for review September 24, 2019 19:11
@ruflin ruflin requested review from skh and jfsiii September 24, 2019 19:12
@ruflin
Copy link
Contributor Author

ruflin commented Sep 24, 2019

@skh I hope this will be useful for you.

Copy link
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 👍 This is really helpful, thank you!

@ruflin ruflin merged commit a61256a into elastic:master Sep 25, 2019
@ruflin ruflin deleted the generator-tool branch September 25, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants