Add default config to dataset #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@exekias Would be great to get your feedback on this. Not sure about the naming. |
exekias
approved these changes
Nov 18, 2019
Not all datasets are enabled by default. Having a config per dataset should allow the UI to decide which ones should be enabled by default. The default should be false.
ruflin
force-pushed
the
default-dataset
branch
from
308fab4 to
0beb204
Compare
|
@exekias I assume your 👍 means you are ok with the name? Lets go with it then for now. |
|
Yes, sorry for not saying that explicitly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all datasets are enabled by default. Having a config per dataset should allow the UI to decide which ones should be enabled by default. The default should be false.