Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package name to dataset #189

Merged
merged 4 commits into from
Jan 9, 2020
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Dec 17, 2019

The package name in the dataset is useful in EPM. For this reason it is added here.

@ruflin ruflin added the ingest label Dec 17, 2019
@ruflin ruflin self-assigned this Dec 17, 2019
@ruflin ruflin requested a review from jfsiii December 17, 2019 20:05
@ruflin
Copy link
Contributor Author

ruflin commented Dec 17, 2019

@jfsiii I have the suspicion that later on package.version will also become useful, not only the name. For now I only added the name, but later we could convert it to:

{ 
  "package": {
    "name": "foo",
    "version": "1.2.3"
  }
}

ruflin added 2 commits January 6, 2020 14:15
The package name in the dataset is useful in EPM. For this reason it is added here.
@ruflin
Copy link
Contributor Author

ruflin commented Jan 9, 2020

@jfsiii Could you help me to get the necessary changes ready on the EPM side if you are good with the change?

@jfsiii
Copy link

jfsiii commented Jan 9, 2020

@ruflin sure thing. Sorry for the lag. Thanks for the ping.

We already have Dataset.package so I think the only work is removing the code that manually inserts it. I'll post a PR soon.

Copy link

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. EPM already expects this property so I think it can merge without breaking anything. EPM will need an update to use this value instead of the one it injects, however.

@ruflin ruflin merged commit 3114374 into elastic:master Jan 9, 2020
@ruflin ruflin deleted the dataset-package branch January 9, 2020 13:56
@ruflin
Copy link
Contributor Author

ruflin commented Jan 9, 2020

Merged. Will redeploy after the demo today ;-)

@jfsiii
Copy link

jfsiii commented Jan 9, 2020

I just remembered that @neptunian has a PR that changes this to packageName. elastic/kibana#54037

So that should either be reverted to package or the registry should use packageName so there's agreement

@ruflin
Copy link
Contributor Author

ruflin commented Jan 9, 2020

Good point, lets stick to package for now if @neptunian is ok with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants