-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package name to dataset #189
Conversation
@jfsiii I have the suspicion that later on
|
The package name in the dataset is useful in EPM. For this reason it is added here.
c9be120
to
d92b456
Compare
@jfsiii Could you help me to get the necessary changes ready on the EPM side if you are good with the change? |
@ruflin sure thing. Sorry for the lag. Thanks for the ping. We already have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. EPM already expects this property so I think it can merge without breaking anything. EPM will need an update to use this value instead of the one it injects, however.
Merged. Will redeploy after the demo today ;-) |
I just remembered that @neptunian has a PR that changes this to So that should either be reverted to |
Good point, lets stick to |
The package name in the dataset is useful in EPM. For this reason it is added here.