Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make README.md file a requirement #287

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Mar 23, 2020

Before the README file was not a requirement. But I think it is important that each package contains one. This also makes it possible to validate it is there. In the case of the system package, the README was there but with a typo and we didn't detect it.

@ruflin ruflin requested a review from mtojek March 23, 2020 10:33
@ruflin ruflin self-assigned this Mar 23, 2020
ruflin added 2 commits March 23, 2020 12:43
Before the README file was not a requirement. But I think it is important that each package contains one. This also makes it possible to validate it is there. In the case of the system package, the README was there but with a typo and we didn't detect it.
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge if it goes green.

@ruflin ruflin merged commit c902ef7 into elastic:master Mar 23, 2020
@ruflin ruflin deleted the require-readme branch March 23, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants