Add multiple config for datasource #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some datasources can only be installed once per agent config. An example for this is the endpoint datasource. This introduces the multiple:false flag on the datasource level
jen-huang
approved these changes
Apr 21, 2020
|
@mtojek This might have some effects on the generator. |
mtojek
reviewed
Apr 22, 2020
CHANGELOG.md
Outdated
| @@ -22,6 +22,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| * Make README.md file a required file for a package. [#287](https://github.com/elastic/integrations-registry/pull/287) | |||
| * Add stream fields to each dataset [#296](https://github.com/elastic/integrations-registry/pull/296) | |||
| * Add `all` query param to return all packages. By default is set false. [#301](https://github.com/elastic/integrations-registry/pull/301) | |||
| * Add `multiple` config for datasource. By default true. [#](https://github.com/elastic/integrations-registry/pull/) | |||
There was a problem hiding this comment.
nit: missing reference to PR?
mtojek
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some datasources can only be installed once per agent config. An example for this is the endpoint datasource. This introduces the multiple:false flag on the datasource level