From a98a8ea9afe826d368fd905060849ca4e696b2c2 Mon Sep 17 00:00:00 2001 From: "Christiane (Tina) Heiligers" Date: Mon, 16 Oct 2023 09:11:51 -0700 Subject: [PATCH] Removes skip from inner tests where the outer test is already skipped --- test/functional/apps/dashboard/group5/embed_mode.ts | 4 ++-- test/functional/apps/discover/group1/_shared_links.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/functional/apps/dashboard/group5/embed_mode.ts b/test/functional/apps/dashboard/group5/embed_mode.ts index 6e15f35f17fe9..fc7b92ab5fb8d 100644 --- a/test/functional/apps/dashboard/group5/embed_mode.ts +++ b/test/functional/apps/dashboard/group5/embed_mode.ts @@ -80,8 +80,8 @@ export default function ({ await testSubjects.missingOrFail('superDatePickerToggleQuickMenuButton'); await testSubjects.existOrFail('globalQueryBar'); }); - // failed test. See https://github.com/elastic/kibana/issues/163207 - it.skip('renders as expected', async () => { + + it('renders as expected', async () => { await PageObjects.dashboard.waitForRenderComplete(); const percentDifference = await screenshot.compareAgainstBaseline( 'dashboard_embed_mode', diff --git a/test/functional/apps/discover/group1/_shared_links.ts b/test/functional/apps/discover/group1/_shared_links.ts index c31efcea788af..e8f79ea1b427a 100644 --- a/test/functional/apps/discover/group1/_shared_links.ts +++ b/test/functional/apps/discover/group1/_shared_links.ts @@ -178,8 +178,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { return true; }); }); - // Failed test. See https://github.com/elastic/kibana/issues/167405 - it.skip("sharing hashed url shouldn't crash the app", async () => { + + it("sharing hashed url shouldn't crash the app", async () => { const currentUrl = await browser.getCurrentUrl(); await browser.clearSessionStorage(); await browser.get(currentUrl, false);