Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Bail out of suggestion rendering if load times are too long #100345

Closed
flash1293 opened this issue May 19, 2021 · 2 comments
Closed

[Lens] Bail out of suggestion rendering if load times are too long #100345

flash1293 opened this issue May 19, 2021 · 2 comments
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Suggestions are expensive because every single one has the performance characteristics of a separate rendered chart (especially on Elasticsearch side in terms of generated queries).

If rendering is slow, we should stop rendering suggestions of fall back to simple icons instead.

We need to decide on a metric when to trigger this behavior and when to kick rendering back in - I suggest the following:

  • If a suggestion takes longer than 30s (can be detected by waiting for onData callback), stop rendering suggestions
  • Store this in a flag in the module state (will stick with the session - a refresh will bring back rendered suggestions)

Show a little warning icon next to the suggestion refresh button to make it obvious what's happening.

@flash1293 flash1293 added performance Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels May 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Feb 15, 2023
@stratoula
Copy link
Contributor

We don't rendert the charts in suggestions in recent kibana versions so this is not relevant anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants