Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Event Filter Name does not truncate on the UI #101376

Closed
muskangulati-qasource opened this issue Jun 4, 2021 · 12 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0

Comments

@muskangulati-qasource
Copy link

muskangulati-qasource commented Jun 4, 2021

Describe the feature
Event Filter Name does not truncate on the UI

Build Details:

VERSION: 7.14.0-SNAPSHOT
BUILD: 41434
COMMIT: 88615e49f65668b3f8ea707c0bb580580189c297
ARTIFACT: https://artifacts-api.elastic.co/v1/search/7.14.0-SNAPSHOT

Preconditions

  1. Elastic 7.14.0 environment should be deployed.

Steps to Reproduce

  1. Navigate to Administration Tab under the Security
  2. Go to the Event Filter Tab
  3. Add a new filter Event entry by adding a long name without any space & save the value
  4. Observe that the name is not truncated

Test data
N/A

Impacted Test case(s)
N/A

Actual Result
Event Filter Name does not truncate on the UI

Expected Result
Event Filter Name should be truncated and wrapped on the UI

What's Working
N/A

What's Not Working
N/A

Screenshot
NameDoesNotTruncate

Logs:
N/A

@muskangulati-qasource muskangulati-qasource added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jun 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@muskangulati-qasource muskangulati-qasource added 7.14 candidate impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Defend Workflows “EDR Workflows” sub-team of Security Solution labels Jun 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@muskangulati-qasource
Copy link
Author

@manishgupta-qasource please review!!

@manishgupta-qasource
Copy link

Reviewed & Assigned to @kevinlog

@dasansol92
Copy link
Contributor

Split text in different lines is enough or do we need to cut the text at some point? The name field has a max-length on the form. Attaching image with a max length name with a lines split:
Screenshot 2021-06-07 at 12 58 37

cc: @kevinlog @bfishel @caitlinbetz

@kevinlog
Copy link
Contributor

kevinlog commented Jun 7, 2021

@dasansol92 splitting the text as you have above looks good to me. As long as it doesn't overflow that we're OK. In addition, I think long names will be rare - as long as we're handling it in some way, then we're OK.

@bfishel @caitlinbetz let me know if you think differently

@dasansol92
Copy link
Contributor

PR: #101481

@dasansol92 dasansol92 added the QA:Ready for Testing Code is merged and ready for QA to validate label Jun 7, 2021
@muskangulati-qasource
Copy link
Author

Hi @kevinlog,

We tested this ticket on the latest 7.14.0-SNAPSHOT build and the issue is now fixed.
However, we have 1 query, please look into the same and confirm if it is expected:

Query
The Name on Trusted Apps is truncated and a tooltip shows up for the same when we hover on it. However, for the Filter Event Filter Tab, the name is extended and divided. Is it expected? Since both the tabs have inconsistent behaviour

Build Details:

VERSION: 7.14.0-SNAPSHOT
BUILD: 41559
COMMIT: 9838db392e7fcfc12f004b68fb1b09739f131148
ARTIFACT: https://artifacts-api.elastic.co/v1/search/7.14.0-SNAPSHOT

Screenshot:
Trusted App Tab:
TrustedApp

Event Filter Tab:
FilterEvent

cc: @dasansol92

Thanks!!

@dasansol92
Copy link
Contributor

dasansol92 commented Jun 14, 2021

@muskangulati-qasource @kevinlog This is because the card component used in trusted apps is different than the ones used in event filters. We could unify those cards to be displayed in the same way but would need a coordination with the detections team as the event filters card is used for other exceptions

@kevinlog
Copy link
Contributor

Thanks for the insight @dasansol92

@muskangulati-qasource I think we can close this one as is and open an enhancement to unify the cards. @bfishel wanted to redesign them at some point in any case.

@muskangulati-qasource
Copy link
Author

Hi @kevinlog,

Thank you for the update. We have created a new Enhancement ticket to track here: #102188

Hence, closing this ticket & marking it as "Validated".

Thanks!

@muskangulati-qasource muskangulati-qasource removed the QA:Ready for Testing Code is merged and ready for QA to validate label Jun 15, 2021
@muskangulati-qasource muskangulati-qasource added the QA:Validated Issue has been validated by QA label Jun 15, 2021
@muskangulati-qasource
Copy link
Author

Bug Conversion

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. OLM Sprint QA:Validated Issue has been validated by QA Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0
Projects
None yet
Development

No branches or pull requests

5 participants