Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing csp directives configuration #102322

Closed
pgayvallet opened this issue Jun 16, 2021 · 1 comment · Fixed by #102059
Closed

Add missing csp directives configuration #102322

pgayvallet opened this issue Jun 16, 2021 · 1 comment · Fixed by #102059
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

Follow-up of #94414

In #102059, we introduced csp.script_src, csp.worker_src and csp.style_src, as a replacement for csp.rules.

However, to totally get rid of csp.rules, we need to also add the other csp directive, to allow customers to configure them if required.

We don't necessarily need to support all directives, however this list should at least be implemented:

  • connect-src
  • default-src
  • font-src
  • frame-src
  • img-src
  • frame-ancestors
  • report-uri
  • report-to

frame-ancestors may be a tricky one, as it could potentially conflict with server.securityResponseHeaders.disableEmbedding. We may need to add validation between those two config properties

Also see #102059 (comment)

@pgayvallet pgayvallet added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants