Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Sessions] Error state needs retry mechanism #105726

Closed
Dosant opened this issue Jul 15, 2021 · 2 comments
Closed

[Search Sessions] Error state needs retry mechanism #105726

Dosant opened this issue Jul 15, 2021 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@Dosant
Copy link
Contributor

Dosant commented Jul 15, 2021

In case of search status request fail due to network or cluster instability, we assume ERROR_STATE as the same state when es returned search error:

return {
status: SearchStatus.ERROR,
error: i18n.translate('xpack.data.search.statusThrow', {
defaultMessage: `Search status threw an error {message} ({errorCode}) status`,
values: {
message: e.message,
errorCode: e.statusCode || 500,
},
}),
};

In this case, we transition the search session to an error state and then stop checking its search statuses. But it actually might be that the searches will successfully finish later. Also, searches might leave hanging, executing and loading the cluster: #105434

We need to handle that catch close differently. Maybe introduce a retry mechanism, where we would try to check that search status again on the next task run.

@Dosant Dosant added Feature:Search Querying infrastructure in Kibana enhancement New value added to drive a business result Team:AppServices labels Jul 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jul 19, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jul 29, 2021
@lukasolson lukasolson added Feature:Search Sessions bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Sep 20, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 28, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Nov 22, 2021
@petrklapka petrklapka added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:AppServicesSv labels Nov 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added the Icebox label Oct 8, 2024
@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Sessions Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

5 participants