Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph] Switch to SavedObjectClient.resolve #105812

Closed
timroes opened this issue Jul 15, 2021 · 4 comments · Fixed by #111404
Closed

[Graph] Switch to SavedObjectClient.resolve #105812

timroes opened this issue Jul 15, 2021 · 4 comments · Fixed by #111404
Assignees
Labels
blocker Feature:Graph Graph application feature Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.0.0

Comments

@timroes
Copy link
Contributor

timroes commented Jul 15, 2021

We need to switch over to SavedObjectClient.resolve instead of .get in the 8.0 release. This issue tracks work for the graph-workspace saved object loading.
This issue will also track progress for making Graph Saved Object share-capable. It has currently nameSpaceType: single. It should be updated to multiple_isolated.
For more details see #100489

@timroes timroes added blocker Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 labels Jul 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@jportner
Copy link
Contributor

In case anyone is following this issue but not the linked meta-issue (#100489):

I published the Sharing Saved Objects developer guide, please take a look before proceeding with the implementation. And of course, please reach out if you run into any problems!

Note that there are a few more steps than just switching to use resolve(), there are some server side changes too, see the dev guide for more details. I think you only need to be concerned about Steps 2-4 but it would be good for someone on your team to verify 👍

@mbondyra
Copy link
Contributor

I started working on this one, but let's wait till graph is deangularized before continuing. I will pick up the next one.

@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:Graph Graph application feature Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants