Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate role mappings JSON editor to use the monaco-based editor #107078

Closed
Tracked by #106931
legrego opened this issue Jul 28, 2021 · 1 comment · Fixed by #107459
Closed
Tracked by #106931

Migrate role mappings JSON editor to use the monaco-based editor #107078

legrego opened this issue Jul 28, 2021 · 1 comment · Fixed by #107459
Assignees
@jportner
Labels
chore Feature:Users/Roles/API Keys impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@legrego
Copy link
Member

legrego commented Jul 28, 2021 •
edited
Loading

x-pack/plugins/security/public/management/role_mappings/edit_role_mapping/rule_editor_panel/json_rule_editor.tsx uses the deprecated EuiCodeEditor component, which is slated for removal in the 7.16 timeframe.

Deprecation notice: elastic/eui#3807
Meta issue: #106931
@legrego legrego mentioned this issue Jul 28, 2021
Open
42 tasks
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 28, 2021
@legrego legrego added chore Feature:Users/Roles/API Keys Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Jul 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 28, 2021
@legrego legrego changed the title x-pack/plugins/security/public/management/role_mappings/edit_role_mapping/rule_editor_panel/json_rule_editor.tsx Migrate role mappings JSON editor to use the monaco-based editor Jul 28, 2021
@jportner jportner self-assigned this Aug 2, 2021
@jportner jportner mentioned this issue Aug 2, 2021
Merged
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 4, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jportner jportner

Labels
chore Feature:Users/Roles/API Keys impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change Role Mappings editor to use CodeEditor jportner/kibana
3 participants
@legrego @jportner @elasticmachine