Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config.set() with a custom config to define user-facing description text shown in Advanced Settings #10863

Closed
tsullivan opened this issue Mar 23, 2017 · 8 comments
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@tsullivan
Copy link
Member

It looks like when I have a plugin that calls config.set(CONFIG_NAME, value) to dynamically add a config value to store in the .kibana index, there is no way to add a description for this settings.

Built-in config options have a way to set a description. It would be great if this was possible for custom config settings as well.

Illustration:
no description custom config

cc @skearns64

@spalger
Copy link
Contributor

spalger commented Mar 23, 2017

I think being able to define your configs is reasonable, but I really don't think it should be a part of the config.get() API. All of the uiSettings are calculated server-side and the custom plugin definitions (with things like types, descriptions, and defaults) should go there.

@tsullivan
Copy link
Member Author

tsullivan commented Mar 23, 2017 via email

@spalger
Copy link
Contributor

spalger commented Mar 23, 2017

Nope, unfortunately it is not possible today.

@tsullivan
Copy link
Member Author

I agree with the approach you described. Does this issue need to stay open, or is it a known part of config re-architecture?

@spalger
Copy link
Contributor

spalger commented Mar 24, 2017

This should definitely stay open. The platform work we're doing doesn't address this need. Might as well implement it in the current system if it's something you'd like to see soon.

@xycloud
Copy link

xycloud commented Mar 27, 2017

awesome feature,+1

@andrewkcarter
Copy link

I would really like to see it too. Also, the ability to provide the type for the value, i.e json.

@tsullivan
Copy link
Member Author

It should be possible for a plugin to define its UI Settings in the uiExports block of a plugin definition.

@tsullivan tsullivan added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed :Management labels May 27, 2017
@epixa epixa added enhancement New value added to drive a business result and removed release_note:enhancement labels May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

6 participants