Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many toast messages appear when license is about to expire #109948

Closed
smith opened this issue Aug 24, 2021 · 8 comments
Closed

Many toast messages appear when license is about to expire #109948

smith opened this issue Aug 24, 2021 · 8 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@smith
Copy link
Contributor

smith commented Aug 24, 2021

Kibana version: master

Describe the bug: If your license is near expiration, many pages give you a whole load of toast messages about it.

Steps to reproduce:

  1. Have a license that will expire in 3 days
  2. Open Discover or Dashboards
  3. Get bombarded

Expected behavior:

  1. Have a license that will expire in 3 days
  2. Open any page
  3. Get one unobtrusive yet clear message about the expiration

Screenshots (if relevant):

CleanShot 2021-08-24 at 15 12 07

@smith smith added the bug Fixes for quality problems that affect the customer experience label Aug 24, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 24, 2021
@legrego legrego added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Aug 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 24, 2021
@marius-dr
Copy link
Member

I guess this can be bundled together with this error message as well, since the same thing should happen in this case too (security not explicitly disabled, just disabled by default in 7.x and lower). And the same solution, messages like this that come from ES should be bundled together:
metricbeat app check metricbeat Dashboard Metricbeat System Overview ECS should match snapshot

@pgayvallet
Copy link
Contributor

I'm not sure exactly where these messages are coming from to be honest. The licensing plugin's check only show a banner when the license is really expired:

if (license.status === 'expired' && !this.isLicenseExpirationBannerShown && this.coreStart) {
this.isLicenseExpirationBannerShown = true;
this.showExpiredBanner(license);
}

@marius-dr
Copy link
Member

I can help point in the right direction: elastic/elasticsearch#70114 I assume they come from the REST response from Elasticsearch and Kibana somehow displays them for every single request.

@mshustov
Copy link
Contributor

Open Discover or Dashboards

That makes me think this behavior is introduced by #103744 cc @lukasolson

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@lukeelmers lukeelmers removed the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Sep 7, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Sep 27, 2021
@lukeelmers
Copy link
Member

Related #67270 #69697 #62649

@lukasolson
Copy link
Member

I believe this was addressed by #117252, but if it wasn't, then it should be looped in with #116686, so closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

No branches or pull requests

8 participants