Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core deprecations service] Make deprecationType required field #111070

Open
alisonelizabeth opened this issue Sep 2, 2021 · 2 comments
Open

[Core deprecations service] Make deprecationType required field #111070

alisonelizabeth opened this issue Sep 2, 2021 · 2 comments
Assignees
@Bamieh
Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@alisonelizabeth
Copy link
Contributor

Currently the deprecationType field is optional when registering a deprecation (implemented via #96060).

I propose making this a required field, even if it means introducing an "uncategorized" type. Otherwise, it becomes unclear if the deprecation type does not fall under config or feature, or if the engineer forgot to define this field when registering the deprecation.

The type appears as a column in Upgrade Assistant, and users can also filter by type.
Screen Shot 2021-09-02 at 7 48 47 PM
@alisonelizabeth alisonelizabeth added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Sep 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@alisonelizabeth alisonelizabeth mentioned this issue Sep 2, 2021
Merged
@pgayvallet
Copy link
Contributor

@Bamieh is this still something that would make sense, or are we good closing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bamieh Bamieh

Labels
enhancement New value added to drive a business result Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pgayvallet @alisonelizabeth @Bamieh @elasticmachine