Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert default exports to named #11220

Closed
6 of 7 tasks
stacey-gammon opened this issue Apr 13, 2017 · 4 comments
Closed
6 of 7 tasks

Convert default exports to named #11220

stacey-gammon opened this issue Apr 13, 2017 · 4 comments
Assignees

Comments

@stacey-gammon
Copy link
Contributor

stacey-gammon commented Apr 13, 2017

This is a meta issue to track the gradual and eventual removal of default exports from all code under this repository. This will bring the code in compliance with https://github.com/elastic/kibana/blob/master/style_guides/js_style_guide.md#use-named-exports-only.

For ease of review, this issue will be resolved via a series of PRs, each focusing on a section of the codebase. Once all the checks are in place an eslint rule can be placed at the top level. In the meantime, eslint rules can be introduced in sub directories to ensure compliance in the meantime.

  • src/core_plugins/kibana/public
  • ui/public/
    • ui/public/agg_response/*
    • ui/public/courier/*
    • ui/public/A - M
    • ui/public/N - Z
  • The rest. :)
@LeeDr
Copy link

LeeDr commented Aug 13, 2018

@stacey-gammon can this be closed?

If not, could you please add a team label to it?

@stacey-gammon
Copy link
Contributor Author

Not being actively worked on anymore. @spalger I seem to recall you recently opened up an issue to turn on a lint rule for default exports. Am I imagining that? If we have that issue, we can close this one.

@spalger
Copy link
Contributor

spalger commented Aug 14, 2018

That was for TSLint

@thomasneirynck
Copy link
Contributor

Seems we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants