Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Update canvas expressions initialization to use the correct expressions services contract #112596

Closed
dokmic opened this issue Sep 20, 2021 · 2 comments
Closed

[Canvas] Update canvas expressions initialization to use the correct expressions services contract #112596

dokmic opened this issue Sep 20, 2021 · 2 comments
Labels
Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@dokmic
Copy link
Contributor

dokmic commented Sep 20, 2021

Result of #106509.

Summary

The following files are calling expressions setup service methods that are supposed to belong to the start service:

Those methods are marked as deprecated and will be removed from the setup service typings.
@dokmic dokmic added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Canvas labels Sep 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@dokmic dokmic mentioned this issue Sep 20, 2021
Merged
3 tasks
@cqliu1 cqliu1 added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Mar 9, 2023
@nreese
Copy link
Contributor

nreese commented Apr 6, 2023

Closing as not planned

@nreese nreese closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Canvas impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nreese @cqliu1 @dokmic @elasticmachine