Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect external URL allow list in vega #113093

Closed
flash1293 opened this issue Sep 27, 2021 · 1 comment · Fixed by #113720
Closed

Respect external URL allow list in vega #113093

flash1293 opened this issue Sep 27, 2021 · 1 comment · Fixed by #113720
Assignees
@DianaDerevyankina
Labels
enhancement New value added to drive a business result Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Part of #85975

As explained in the linked issue, the global external URL allow list should be respected in links in vega. If vis_type_vega.enableExternalUrls is set to false, no URLs should be allowed.
@flash1293 flash1293 added Feature:Vega Vega visualizations enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@flash1293 flash1293 mentioned this issue Sep 27, 2021
Closed
9 tasks
@DianaDerevyankina DianaDerevyankina mentioned this issue Oct 5, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DianaDerevyankina DianaDerevyankina

Labels
enhancement New value added to drive a business result Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect external URL allow list in vega DianaDerevyankina/kibana
3 participants
@flash1293 @elasticmachine @DianaDerevyankina