Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Platform] - Clean up es-lint disables (@elastic/eui/href-or-on-click) #113709

Open
yctercero opened this issue Oct 3, 2021 · 2 comments
Open

[Security Solution][Platform] - Clean up es-lint disables (@elastic/eui/href-or-on-click) #113709

yctercero opened this issue Oct 3, 2021 · 2 comments
Labels
good first issue low hanging fruit Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@yctercero
Copy link
Contributor

In an effort to improve code quality, platform team looked through team's linter rules and our use of es-lint-disable. There are some low hanging fruit where we could remove these instances where we've disabled rules.

Looks like there are some known/valid use cases of this in Kibana. Not all instances may need to be removed but might want to double check that we're following the suggested methods: elastic/eui#1668

Simply search "@elastic/eui/href-or-on-click" within the security_solution folder. When creating this ticket, there were 7 instances of it being disabled.
@yctercero yctercero added good first issue low hanging fruit Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform Security Solution Platform Team labels Oct 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@deepto98
Copy link

deepto98 commented Oct 5, 2021

@yctercero Hi, I'd like to pick this up too, can you please assign this to me?

@yctercero yctercero added Team:Detection Engine Security Solution Detection Engine Area and removed Team:Security Solution Platform Security Solution Platform Team labels May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue low hanging fruit Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yctercero @elasticmachine @deepto98