-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Graph] Use ExternalUrl service for checking drilldown URL links #113718
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@timroes The way I understood this setting is to allow everything not in the list (just how Graph and TSVB are doing it today). The issue you linked also includes this sentence:
If you want to build a blacklist, I guess you can do an |
Okay, sorry then let me rephrase the question. I meant less the behavior of the list but the behavior of our apps. I.e. what would happen if a graph/tsvb drilldown contains a URL that has |
Got it, good point. we didn't discuss it explicitly, I assumed it would work the same way as vega which is simply not rendering the text as link. Not sure whether a good fit for Graph |
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
See #85975 for more details.
We should validate Drilldown URLs configured in Graph using this service. Not yet clear what we should do, if a configured URL breaks with this list.
@flash1293 Do you have discussed this already for TSVB, how we're handling URLs that are not in the allowlist?
The text was updated successfully, but these errors were encountered: