Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Side nav icons need alt text #11840

Closed
cjcenizal opened this issue May 17, 2017 · 2 comments
Closed

Accessibility: Side nav icons need alt text #11840

cjcenizal opened this issue May 17, 2017 · 2 comments
Labels
Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

The icon that precedes each icon (e.g., ) is an <img> element with no alt attribute. Because these images are decorative, they should have null alternative text (alt="").
@cjcenizal cjcenizal added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label May 17, 2017
@cjcenizal cjcenizal changed the title Accessibility: Side nav icons needs alt text Accessibility: Side nav icons need alt text May 17, 2017
@cjcenizal cjcenizal mentioned this issue May 17, 2017
Closed
38 tasks
@cjcenizal cjcenizal mentioned this issue Jun 6, 2017
Closed
4 tasks
@cjcenizal
Copy link
Contributor Author

Even better, let's use a <nav> element and aria-label to provide more guidance. We should also fix the icon element to have aria-hidden="true", not just aria-hidden.

@timroes timroes mentioned this issue Jul 4, 2017
Closed
@timroes
Copy link
Contributor

timroes commented Jul 6, 2017

Fixed with #12656 . img are now all aria-hidden="true"

@timroes timroes closed this as completed Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Project:Accessibility Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timroes @cjcenizal