Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Discover field chooser skips heading levels #11851

Closed
cjcenizal opened this issue May 17, 2017 · 3 comments
Closed

Accessibility: Discover field chooser skips heading levels #11851

cjcenizal opened this issue May 17, 2017 · 3 comments
Assignees
@aphelionz
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented May 17, 2017 •
edited
Loading

This component contains skipped heading levels (e.g., the "Selected Fields" <h5>).

See #11519 for related info.
@cjcenizal cjcenizal added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label May 17, 2017
@cjcenizal cjcenizal mentioned this issue May 17, 2017
Closed
38 tasks
@aphelionz aphelionz self-assigned this May 24, 2017
@aphelionz
Copy link
Contributor

@cjcenizal Adding an id attribute and tabindex="0" to these elements will add them to the tab index. I noticed that ids are typically id="camel_case". Anything else I should know before I submit my first PR?

@aphelionz aphelionz mentioned this issue May 26, 2017
Closed
2 tasks
@cjcenizal cjcenizal mentioned this issue Jun 6, 2017
Closed
21 tasks
@aphelionz
Copy link
Contributor

@cjcenizal This is ready to close

@cjcenizal
Copy link
Contributor Author

Addressed by #12211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aphelionz aphelionz

Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aphelionz @cjcenizal