Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Refactor rate aggregation for Metric Threshold Alerts to eliminate "Drop Partial Buckets" #118820

Closed
simianhacker opened this issue Nov 17, 2021 · 0 comments · Fixed by #126214
Closed

[Metrics UI] Refactor rate aggregation for Metric Threshold Alerts to eliminate "Drop Partial Buckets" #118820

simianhacker opened this issue Nov 17, 2021 · 0 comments · Fixed by #126214
Labels
enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Project: Actionable Observability - DEPRECATED Deprecated - Do not use Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"

Comments

@simianhacker
Copy link
Member

simianhacker commented Nov 17, 2021 •
edited
Loading

Instead of querying for the last 5 time units, taken from FOR THE LAST x units, we should query for the last 2 units of data then create 2 buckets with a date_range aggregation and manually subtract the first bucket from the second bucket.

This would eliminate the need for the “drop partial buckets” feature and provide a more accurate result. It would also be more performant because we would query less data.
@simianhacker simianhacker added enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Project: Actionable Observability - DEPRECATED Deprecated - Do not use Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Nov 17, 2021
@simianhacker simianhacker changed the title [Metrics UI] Refactor rate aggregation for Metric Threshold to eliminate "Drop Partial Buckets" [Metrics UI] Refactor rate aggregation for Metric Threshold Alerts to eliminate "Drop Partial Buckets" Nov 17, 2021
@simianhacker simianhacker mentioned this issue Jan 14, 2022
Merged
4 tasks
@simianhacker simianhacker mentioned this issue Feb 14, 2022
Closed
2 tasks
@simianhacker simianhacker mentioned this issue Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Project: Actionable Observability - DEPRECATED Deprecated - Do not use Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Projects
None yet
Milestone
No milestone
1 participant
@simianhacker