Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated Rules view for Observability rules #119100

Closed
18 tasks done
vinaychandrasekhar opened this issue Nov 18, 2021 · 13 comments
Closed
18 tasks done

Dedicated Rules view for Observability rules #119100

vinaychandrasekhar opened this issue Nov 18, 2021 · 13 comments
Assignees
Labels
8.2 candidate considered, but not committed, for 8.2 release Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.2.0 v8.3.0

Comments

@vinaychandrasekhar
Copy link

vinaychandrasekhar commented Nov 18, 2021

Describe the feature:
Create a dedicated rules view for managing Observability rules.

  1. Shows rules specific to Observability
  2. Shows last response status for each rule
  3. 'Create rule' flyout shows only Observability rule types for selection
  4. Retains Observability context (i.e., left hand navigation pane showing Observability navigation)
  5. Clicking 'Manage rules' in the Alerts view brings the user to this new dedicated rules view
  6. This new view is included in the left hand navigation pane under "Overview" where Cases and Alerts are currently listed (TBD: is this the correct place to list the alert related links?)

Design work

Rules - Confirmation toast

Rule detail view

Figma file
Prototype

Implementation Tickets

@vinaychandrasekhar vinaychandrasekhar added Theme: rac label obsolete v8.1.0 Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" 8.1 candidate labels Nov 18, 2021
@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Nov 22, 2021

Design doc
Design issue

@katrin-freihofner
Copy link
Contributor

Open questions

  • What should the “last response” column show?
  • What does a 'Create rule' flyout for Observability rule types look like? How does it work?
  • From a users view, does it make sense that the rules page is available in the solution navigation?

@katrin-freihofner
Copy link
Contributor

As discussed in our meeting I opened the following design issues:
Define navigation and user flow for rules view
Design create rule flyout for Observability rules

@katrin-freihofner
Copy link
Contributor

What we should also be working on is the rules details view.

@simianhacker
Copy link
Member

I feel like #119102 should just be a feature of the dedicated rules view instead of seperate epic task.

@jasonrhodes
Copy link
Member

@katrin-freihofner / @vinaychandrasekhar do you all mind getting images of the screens we want to focus on for the first "MVP" of this idea and adding them as images to this epic (as opposed to Figma)? That would be a big help to further our refinement of implementation tickets. Thanks!

@mgiota mgiota self-assigned this Jan 14, 2022
@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Jan 14, 2022

@jasonrhodes I exported and added two example designs to the description. The full design can be found here. Exported images tend to age very quickly, that is why I suggest always referring to the working file (Figma).

@hbharding build a prototype and more screens to show specific interactions and details. Once you have split down the work we can contribute these to the individual engineering issues.

@katrin-freihofner
Copy link
Contributor

Please be aware that some design details are still missing: https://github.com/elastic/observability-design/issues/127

@jasonrhodes
Copy link
Member

Some thoughts/related notes about how to query for "observability" rules:

I'm not sure it's possible to query for "observability", but rather for individual rule types (called alertType still, possibly) ... so we may need to keep a list of observability rule types for this kind of query. It would be great if this was registered somewhere but I don't think it is currently.

@katrin-freihofner
Copy link
Contributor

I'm still working on a couple of details, especially for the rule details view. Please reach out if you have any questions in the meantime and add me to any PRs. I will add any updates here.

@vinaychandrasekhar
Copy link
Author

vinaychandrasekhar commented Mar 14, 2022

Hi @mgiota - suggestions on priority for remaining tickets. cc @simianhacker

Must-have for 8.2 in priority order:

Nice-to-have for 8.2 in priority order:

Unknown / need more info:

@fkanout
Copy link
Contributor

fkanout commented Apr 4, 2022

@katrin-freihofner, could you help me understand what the tags in the Rules alerts table are representing. I couldn't find any details.

@mgiota
Copy link
Contributor

mgiota commented Apr 12, 2022

@fkanout I was wondering the same. I was able to find an answer by looking into the Figma file.

Screenshot 2022-04-12 at 15 47 13

Screenshot 2022-04-12 at 15 47 23

User can specify the tags in the Rule create/edit flyout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.2 candidate considered, but not committed, for 8.2 release Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Theme: rac label obsolete v8.2.0 v8.3.0
Projects
None yet
Development

No branches or pull requests

7 participants