Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Remove short-term solution to detecting ESS cname & URL #120497

Closed
Tracked by #115784
joshdover opened this issue Dec 6, 2021 · 1 comment
Closed
Tracked by #115784

[Fleet] Remove short-term solution to detecting ESS cname & URL #120497

joshdover opened this issue Dec 6, 2021 · 1 comment
Labels
Feature:Unified Integrations Unified Integrations view feature Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@joshdover
Copy link
Contributor

joshdover commented Dec 6, 2021

In 7.16 we added a deployment details pop-out on the Unified Integrations app to help users find their public URL for connecting to Elasticsearch.

Because Kibana does not know the public URL for on-prem deployments or ECE deployments, we added a less than ideal solution that matches on ESS's known public cnames to determine if we should show the pop-out or not:

// If the cname doesn't start with a known prefix, we can't display the flyout.
// TODO: dover - this is a short term solution, see https://github.com/elastic/kibana/pull/114287#issuecomment-940111026
if (
!(
cname.endsWith('elastic-cloud.com') ||
cname.endsWith('found.io') ||
cname.endsWith('found.no') ||
cname.endsWith('foundit.no')
)
) {
return null;
}

We should replace this with a dedicated config value passed into the xpack.cloud.* config that includes the public ES URL. Something like publicElasticsearchUrl. Instead of being Cloud-specific, this could also be a generic feature that we could use for on-prem as well. For instance this could be supplied to the Core config key elasticsearch.publicUrl which we could then populate on ESS, ECE, and document for users to configure themselves. cc @elastic/kibana-core

@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 6, 2021
@joshdover joshdover changed the title Remove short-term solution to detecting ESS cname & URL [Fleet] Remove short-term solution to detecting ESS cname & URL Dec 6, 2021
@joshdover joshdover added Feature:Unified Integrations Unified Integrations view feature Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture labels Dec 6, 2021
@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 6, 2021
@joshdover
Copy link
Contributor Author

fixed in #124020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Unified Integrations Unified Integrations view feature Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

1 participant