Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize panel time range display auto-refresh UI #122135

Closed
Dosant opened this issue Dec 29, 2021 · 1 comment · Fixed by #122167
Closed

Customize panel time range display auto-refresh UI #122135

Dosant opened this issue Dec 29, 2021 · 1 comment · Fixed by #122167
Labels
bug Fixes for quality problems that affect the customer experience Feature:Embedding Embedding content via iFrame good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort regression

Comments

@Dosant
Copy link
Contributor

Dosant commented Dec 29, 2021

Kibana version: main (8.1)

Describe the bug:

Customize panel time range display auto-refresh UI.
We don't support per panel auto-refresh, so we shouldn't display that UI:

Screen Shot 2021-12-29 at 15 16 56

Steps to reproduce:

  1. Go to dashboard
  2. Pick a panel and select "customize time range"
  3. See the auto-refresh in a dialog

Expected behavior:

No auto-refresh

Any additional context:

Likely regressed with recent changes in EUI in #120935

Most likely EuiSuperDatePicker component now displays auto-refresh UI when we pass isPaused and it didn't do it before (cc @elastic/eui-design for visibility for this tiny regression/implicit bugfix)

I think we shouldn't pass it in this component and removing the prop will fix the issue:

kibana/x-pack/plugins/ui_actions_enhanced/public/customize_time_range_modal.tsx

Line 117 in b714f41

isPaused={false}

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Feature:Embedding Embedding content via iFrame regression loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:AppServicesUx labels Dec 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@Dosant Dosant mentioned this issue Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Embedding Embedding content via iFrame good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Embeddable] fix customize time range displays auto-refresh option Dosant/kibana
2 participants
@Dosant @elasticmachine