Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Discover table column buttons aren't keyboard accessible #12230

Closed
cjcenizal opened this issue Jun 7, 2017 · 1 comment
Closed

Accessibility: Discover table column buttons aren't keyboard accessible #12230

cjcenizal opened this issue Jun 7, 2017 · 1 comment
Assignees
@aphelionz
Labels
Feature:Discover Discover Application Project:Accessibility

Comments

@cjcenizal
Copy link
Contributor

image

The "Remove column", "Move column to the left", and "Move column to the right" buttons all need to be keyboard-accessible. This means they should be hidden using visibility: hidden or opacity: 0 instead of display: none, and they should be <button> elements instead of <i>.
This was referenced Jun 7, 2017
Closed
Merged
@cjcenizal
Copy link
Contributor Author

Fixed by #12217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aphelionz aphelionz

Labels
Feature:Discover Discover Application Project:Accessibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aphelionz @cjcenizal