Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML][Dashboard] Standardize Add Embeddable from Anomaly Explorer Page #122300

Closed
3 tasks done
ThomThomson opened this issue Jan 4, 2022 · 4 comments · Fixed by #123199
Closed
3 tasks done

[ML][Dashboard] Standardize Add Embeddable from Anomaly Explorer Page #122300

ThomThomson opened this issue Jan 4, 2022 · 4 comments · Fixed by #123199
Assignees
@darnautov
Labels
Feature:Anomaly Detection ML anomaly detection Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:ML Team label for ML (also use :ml) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Jan 4, 2022 •
edited by darnautov
Loading

Blocks #103846
Related to #68784

The Add Embeddable from Swimlane Explorer Page should be updated and standardized in order to give users of the ML plugin and ML Swimlane Embeddable an experience which is more aligned with the rest of Kibana.

  • The ability to quick add should be removed, so that users cannot modify their dashboard saved objects without being in the dashboard app
  • The Edit in dashboard link should use the embeddable state transfer service to redirect to dashboard with the swimlane embeddable instead of adding the embeddable to the saved object directly then redirecting
  • Remove the last usage of the Dashboard URL generator, replace it with usage of the Dashboard Locator.
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame Feature:Anomaly Detection ML anomaly detection Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ML Team label for ML (also use :ml) labels Jan 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson mentioned this issue Jan 4, 2022
Merged
@darnautov
Copy link
Contributor

hey @ThomThomson! do you need assistance with this?

@ThomThomson
Copy link
Contributor Author

Hi @darnautov, likely we will need to work on it together. I can't prioritize this yet, but it is quite important. Do the requirements sound good to you?

@peteharverson peteharverson changed the title [ML][Dashboard] Standardize Add Embeddable from Swimlane Explorer Page [ML][Dashboard] Standardize Add Embeddable from Anomaly Explorer Page Jan 6, 2022
@darnautov darnautov self-assigned this Jan 17, 2022
@darnautov
Copy link
Contributor

@ThomThomson Yes, sounds good. Can you please point out an example with the usage of the embeddable transfer state service with the Dashboard app?

@darnautov darnautov mentioned this issue Jan 18, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darnautov darnautov

Labels
Feature:Anomaly Detection ML anomaly detection Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:ML Team label for ML (also use :ml) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Standardize Add embeddable flow from the Anomaly Explorer page darnautov/kibana
3 participants
@darnautov @ThomThomson @elasticmachine