Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[indexPatterns] Remove time-based interval support #12242

Closed
4 tasks done
spalger opened this issue Jun 8, 2017 · 6 comments
Closed
4 tasks done

[indexPatterns] Remove time-based interval support #12242

spalger opened this issue Jun 8, 2017 · 6 comments
Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Meta release_note:breaking

Comments

@spalger
Copy link
Contributor

spalger commented Jun 8, 2017

In Kibana 4.3.0 we deprecated creating index patterns with time based intervals, and we are finally going to remove the functionality. I propose the process look something like this:

Why not just pull off the bandaid and completely removing support for time patterns?

  • we can't identify any urgent need for removal
  • moving away from time patterns immediately requires deleting the index pattern, creating a new one, and reassociating all saved objects
  • adding the ability to modify index patterns is mostly blocked by switching to uuids
    • we could update them today and simultaneously update all linked saved objects, but that's error prone and not ideal since uuids are so close.
  • converting a time pattern to a wildcard could require designing aliases or reindexing data if your indexes are not selectable with a wildcard alone
    • [logs-]YYYY.MM[-app-one] would convert to logs-*-app-one, but that also matches logs-not-app-one
@spalger spalger added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:breaking chore Meta labels Jun 8, 2017
@spalger spalger self-assigned this Jun 8, 2017
@spalger
Copy link
Contributor Author

spalger commented Jun 8, 2017

/cc @epixa @tylersmalley @jbudz @archanid

@cjcenizal
Copy link
Contributor

cjcenizal commented Jun 8, 2017

  • allow disabling these warnings in ui settings
  • only show the warning once per index pattern, and once per session

I'm not sure I understand the intention here. What would be the problem if we persistently nagged users about using time-interval index patterns? They're doing something "wrong", so I think it makes sense to keep this warning surfaced and force them to deliberately ignore it each time they see it.

@spalger
Copy link
Contributor Author

spalger commented Jun 14, 2017

@cjcenizal Sorry, missed your comment. The idea was that the person seeing the warning may not be the person who can fix it. The warning is now disabled until there is a simpler method for editing, since even the warning was too suggestive that there was some reasonable method to fix the issue.

@tylersmalley
Copy link
Contributor

We should also remove this from the docs: https://www.elastic.co/guide/en/kibana/current/index-patterns.html

@spalger
Copy link
Contributor Author

spalger commented Jun 23, 2017

Done in 5ca3001 @tylersmalley

@spalger
Copy link
Contributor Author

spalger commented Nov 1, 2018

@elastic/kibana-management is this still incomplete?

@spalger spalger added :Management and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Nov 1, 2018
@spalger spalger removed their assignment Nov 1, 2018
@epixa epixa added the v7.0.0 label Nov 5, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages and removed :Management DO NOT USE labels Nov 27, 2018
@snide snide added v7.2.0 and removed v7.0.0 labels Apr 10, 2019
@lukeelmers lukeelmers added :AppArch Feature:Data Views Data Views code and UI - index patterns before 8.0 and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 16, 2019
@spalger spalger added v7.2.1 and removed v7.2.0 labels Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Meta release_note:breaking
Projects
None yet
Development

No branches or pull requests

9 participants