Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Integrate package bundling process into kbn bootstrap #124256

Open
kpollich opened this issue Feb 1, 2022 · 7 comments
Open

[Fleet] Integrate package bundling process into kbn bootstrap #124256

kpollich opened this issue Feb 1, 2022 · 7 comments
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Team label for Operations Team

Comments

@kpollich
Copy link
Member

kpollich commented Feb 1, 2022

In #122297 we introduced a step to Kibana's build process to bundle a configured set of packages and store their archives on disk. This process should also be exposed as part of Kibana's bootstrap process for development environments.

@kpollich kpollich added enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team labels Feb 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich changed the title [Fleet] Integrated package bundling process into kbn bootstrap [Fleet] Integrate package bundling process into kbn bootstrap Feb 1, 2022
@kpollich kpollich self-assigned this Feb 4, 2022
@joshdover
Copy link
Contributor

@elastic/kibana-operations Any guidance on how we should do this? We currently have this only implemented for builds but would instead like to have this happen during yarn kbn bootstrap and then the build would be adjusted to only copy the files that were downloaded during bootstrap to the build directory.

Where is the best place to add a kbn:build npm package script? Can we do this in our own plugin's x-pack/plugins/fleet/package.json?

@spalger
Copy link
Contributor

spalger commented Mar 18, 2022

It feels like it makes sense for this to be the "build" process for a package... @mistic I feel like I've asked this before, but could we have a package which is mostly just a BUILD.bazel file that basically just downloads artifacts? Feels like something bazel must support,

@mistic
Copy link
Member

mistic commented Mar 19, 2022

@spalger I need to think about this better but I think we can declare an http_file rule from within the WORKSPACE and then reference this as a dependency in any other BUILD.bazel file as well as proceed with any extra action we need (like for example make it available somewhere in the bazel output folder)

@spalger
Copy link
Contributor

spalger commented Mar 20, 2022

I feel like we should be able to do this from a specific package, not just at the WORKSPACE level. Maybe we just need a custom rule for this, I have a couple other uses in mind.

@joshdover
Copy link
Contributor

@spalger Is a custom rule something we (Fleet team) could help explore in the near term, or is this something you have time to look at?

@spalger
Copy link
Contributor

spalger commented Mar 22, 2022

If y'all want to do some research and try to implement it, I think it's great for more people to have experience here but I also expect that we could pull something together pretty quickly if @mistic thinks it's a worthwhile thing to have in the first place.

@jen-huang jen-huang added the Team:Operations Team label for Operations Team label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:Fleet Team label for Observability Data Collection Fleet team Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

6 participants