Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controls] Allow the control type to be changed when editing existing control #128195

Closed
Heenawter opened this issue Mar 21, 2022 · 3 comments · Fixed by #129385
Closed

[Controls] Allow the control type to be changed when editing existing control #128195

Heenawter opened this issue Mar 21, 2022 · 3 comments · Fixed by #129385
Assignees
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Mar 21, 2022

Follow up to #127524

Describe the feature:

When creating a new control, users are able to select one of many possible control types:

However, when editing an existing control, users are only given the option for the type of control that is being edited.

Ideally, the same options should be present for both menus - however, this requires the ability to replace the control embeddable with one of a different type.

@Heenawter Heenawter added Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:needs-research This issue requires some research before it can be worked on or estimated impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Mar 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@teresaalvarezsoler
Copy link

@Heenawter IMO, the ideal solution would be to allow the user to freely choose another type and another field. However, if this makes things more complex, a quick solution may be to show the other type of control icon disabled. What do you think?

@Heenawter
Copy link
Contributor Author

Heenawter commented Mar 22, 2022

@teresaalvarezsoler Yeah, the field part would naturally be part of this - that hard part is the type switching, not the field switching :) I talked with @andreadelrio about it, and we agreed to avoid disabling certain options, hence why you only see the current type when editing an existing control for now. We should only show the other options once we support switching types

@Heenawter Heenawter self-assigned this Mar 28, 2022
@Heenawter Heenawter added the enhancement New value added to drive a business result label Mar 31, 2022
@Heenawter Heenawter added Project:Controls Feature:Dashboard Dashboard related features labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants