Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Migrating to 8.2 keep old @mappings and @settings component templates #129662

Closed
nchaulet opened this issue Apr 6, 2022 · 6 comments · Fixed by #130758
Closed

[Fleet] Migrating to 8.2 keep old @mappings and @settings component templates #129662

nchaulet opened this issue Apr 6, 2022 · 6 comments · Fixed by #130758
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0

Comments

@nchaulet
Copy link
Member

nchaulet commented Apr 6, 2022

Related to #121184

While testing the upgrade from 8.x and 7.x to 8.2 to the new @package. I found that the @package component template is well created, during the upgrade the old and now unused @mappings and @settings templates are kept around. We should delete these old managed component templates.

Screen Shot 2022-04-04 at 3 50 50 PM

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0 labels Apr 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang
Copy link
Contributor

@joshdover @hop-dev I assume we should delete @mappings in the same way we delete @settings, but welcome your input.

@nchaulet
Copy link
Member Author

@joshdover @hop-dev I assume we should delete @mappings in the same way we delete @settings, but welcome your input.

Actually I do not think we do not delete the @settings neither

@jen-huang
Copy link
Contributor

Actually I do not think we do not delete the @settings neither

Oof, thanks for confirming, I'll update the details here.

@jen-huang jen-huang changed the title [Fleet] Migrating to 8.2 keep old @mappings component template [Fleet] Migrating to 8.2 keep old @mappings and @settings component templates Apr 13, 2022
@hop-dev
Copy link
Contributor

hop-dev commented Apr 14, 2022

Thats right we don't clean them up currently, I meant to bring this up in 8.3 planning sorry, I think we want to fix this for 8.2 or we will be leaving a lot of mess behind. @jen-huang @joshdover I know we are quite full for 8.3 but are you happy for me (or someone) to pick this up?

@jen-huang
Copy link
Contributor

@hop-dev Yep, we agreed that this is a fix that should be backported for 8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v8.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants