Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Controls] Mobile view hides save button in "Edit control" flyout #131874

Closed
Heenawter opened this issue May 9, 2022 · 3 comments
Closed

[Controls] Mobile view hides save button in "Edit control" flyout #131874

Heenawter opened this issue May 9, 2022 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented May 9, 2022 •
edited
Loading

Describe the bug:
Because of the location of the "Delete control" button, the save button is hidden on many mobile views

SaveButtonHidden
@Heenawter Heenawter added the bug Fixes for quality problems that affect the customer experience label May 9, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label May 9, 2022
@Heenawter Heenawter added Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:Controls labels May 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 9, 2022
@Heenawter Heenawter added loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. needs-team Issues missing a team label labels May 9, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label May 9, 2022
@Heenawter Heenawter added the Feature:Dashboard Dashboard related features label May 9, 2022
@ThomThomson
Copy link
Contributor

I wonder if this is something we should fix by using EuiFlex? @andreadelrio

@Heenawter Heenawter mentioned this issue May 10, 2022
Merged
9 tasks
@Heenawter
Copy link
Contributor Author

Heenawter commented May 10, 2022 •
edited
Loading

This actually caused by code that was accidentally left in this PR and I totally didn't even notice - my fault! Doesn't belong as a bug on main so I'll close it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Heenawter @ThomThomson @elasticmachine