Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover][Alerting] Implement editing of data view, query, filters #131920

Closed
dimaanj opened this issue May 10, 2022 · 1 comment · Fixed by #131688
Closed

[Discover][Alerting] Implement editing of data view, query, filters #131920

dimaanj opened this issue May 10, 2022 · 1 comment · Fixed by #131688
Assignees
@dimaanj
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@dimaanj
Copy link
Contributor

dimaanj commented May 10, 2022 •
edited
Loading

We're extending the Elasticsearch query rule in #124534

This is a follow up which will enable editing of the selected data view, query and filters similar to how it works in the index based Elasticsearch query alert rule.

  • The data view popover should show a dropdown allowing the selection of data views, similar like it’s handled in Discover
  • Query and filters add functionality should be used in terms of Unified Search which includ the ability to switch between KQL and Lucene, and saved queries like this
  • Each filter pill should be editable by itself using the popover like in Discover, and it should also be possible to add and remove filter pills.
@dimaanj dimaanj self-assigned this May 10, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label May 10, 2022
@dimaanj dimaanj added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed needs-team Issues missing a team label labels May 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@dimaanj dimaanj added the WIP Work in progress label May 10, 2022
@dimaanj dimaanj mentioned this issue May 10, 2022
Merged
6 tasks
@dimaanj dimaanj removed the WIP Work in progress label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimaanj dimaanj

Labels
Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover][Alerting] Implement editing of dataView, query & filters dimaanj/kibana
2 participants
@elasticmachine @dimaanj