Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork our "marked" dependency to the elastic org #13426

Closed
epixa opened this issue Aug 9, 2017 · 3 comments
Closed

Fork our "marked" dependency to the elastic org #13426

epixa opened this issue Aug 9, 2017 · 3 comments

Comments

@epixa
Copy link
Contributor

epixa commented Aug 9, 2017

marked is an abandoned project that is no longer reliably releasing patch versions of the software. We should fork the project to use in Kibana so we can have control over it for our usage.

This only applies to versions prior to 6.0 since marked should be removed entirely in 6.0.0. See #13425

@uboness
Copy link

uboness commented Aug 9, 2017

why not just pulling the codebase into the kibana project... forking it into the elastic org still makes it publicly available right?

@epixa
Copy link
Contributor Author

epixa commented Aug 9, 2017

@uboness I'm not against this, but we have no precedent for doing this on an entire project, including all the test infrastructure and such. This is something we absolutely want and need to do, but we weren't planning to do it for this particular change.

@uboness
Copy link

uboness commented Aug 9, 2017

not sure how much work is required to pull the codebase in... so I trust your judgement. Just wanted to make sure this option is considered. Also, if we do pull it into the elastic org, please put a HUGE warning in the readme that this is purely internal for Kibana and no one else should use it anywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants