-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Controls] Change Copy for Options List Run Past Timeout #134369
Comments
Pinging @elastic/kibana-presentation (Team:Presentation) |
Totally agree, is not clear at all what this option does. I'm even thinking why we need to expose this complexity to the user, @ThomThomson are they any drawbacks enabling this option? Why don't we have it enabled by default and remove it from here? |
This option was added specifically because of all of the issues raised relating to the Incomplete terms list warning in the experimental input controls. Basically what happens is the following: Some users have certain fields in their data set up in such a way (high cardinality, bad sharding) that makes some options not show up in the results. That was super frustrating for the user. They know that In the old experimental controls, the only way to fix this was to change the In the new Controls, I added this All this to say, we can't remove this feature entirely because it is required in some edge cases. We can't turn it on by default because it would slow down the controls drastically. Something we could do, is maybe hide it under an |
thanks for the explanation @ThomThomson. Adding a question mark icon to explain it better seems the best option, btw is it on by default? |
It's off by default, because in ~80% of cases the settings work well and don't cause any issues. |
makes sense |
@KOTungseth, for the fix of this issue, we may need some copy help! It's a pretty complicated concept we're trying to get across here. |
How about: Label: Display all options |
What about: Label: Remove timeout for displaying values |
@ThomThomson I really like the idea of having an advanced section - would that contain both the items that are currently under "additional settings"? (feels logical to me, but I don't know how frequently the other setting is used) @teresaalvarezsoler I see where you're going here and think we can tighten it up some more to make it more scannable/faster to read. Label: Ignore timeout for results |
Thanks you @kellyemurphy! Looks good to me :) |
Kibana version: 8.3.0 BC3
Elasticsearch version: 8.3.0 BC3
Browser version: chrome latest
Describe the bug: Run past timeout toggle button on controls isn't helping the user. The docs say https://www.elastic.co/guide/en/kibana/master/add-controls.html#create-and-add-controls
It will be be really helpful to explain that to the user using either the copy on the toggle button or a tooltip.
The text was updated successfully, but these errors were encountered: